From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Chen Wandun <chenwandun@huawei.com>
Cc: linux-xfs@vger.kernel.org, bfoster@redhat.com,
dchinner@redhat.com, preichl@redhat.com, sandeen@sandeen.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static
Date: Fri, 20 Dec 2019 08:30:03 -0800 [thread overview]
Message-ID: <20191220163003.GP7489@magnolia> (raw)
In-Reply-To: <20191220095157.42619-1-chenwandun@huawei.com>
On Fri, Dec 20, 2019 at 05:51:57PM +0800, Chen Wandun wrote:
> Fix the following sparse warning:
>
> fs/xfs/libxfs/xfs_trans_resv.c:206:1: warning: symbol 'xfs_rtalloc_log_count' was not declared. Should it be static?
>
> Fixes: b1de6fc7520f ("xfs: fix log reservation overflows when allocating large rt extents")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Urk, oops, good catch!
Especially since the for-next announcement message got totally eaten by
$employer MTA or something. :/
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_trans_resv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
> index 824073a839ac..7a9c04920505 100644
> --- a/fs/xfs/libxfs/xfs_trans_resv.c
> +++ b/fs/xfs/libxfs/xfs_trans_resv.c
> @@ -202,7 +202,7 @@ xfs_calc_inode_chunk_res(
> * blocks as needed to mark inuse MAXEXTLEN blocks' worth of realtime extents,
> * as well as the realtime summary block.
> */
> -unsigned int
> +static unsigned int
> xfs_rtalloc_log_count(
> struct xfs_mount *mp,
> unsigned int num_ops)
> --
> 2.17.1
>
prev parent reply other threads:[~2019-12-20 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 9:51 [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static Chen Wandun
2019-12-20 16:30 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220163003.GP7489@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=chenwandun@huawei.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox