* [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static
@ 2019-12-20 9:51 Chen Wandun
2019-12-20 16:30 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2019-12-20 9:51 UTC (permalink / raw)
To: darrick.wong, linux-xfs, bfoster, dchinner, preichl, sandeen,
linux-kernel
Cc: chenwandun
Fix the following sparse warning:
fs/xfs/libxfs/xfs_trans_resv.c:206:1: warning: symbol 'xfs_rtalloc_log_count' was not declared. Should it be static?
Fixes: b1de6fc7520f ("xfs: fix log reservation overflows when allocating large rt extents")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
fs/xfs/libxfs/xfs_trans_resv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
index 824073a839ac..7a9c04920505 100644
--- a/fs/xfs/libxfs/xfs_trans_resv.c
+++ b/fs/xfs/libxfs/xfs_trans_resv.c
@@ -202,7 +202,7 @@ xfs_calc_inode_chunk_res(
* blocks as needed to mark inuse MAXEXTLEN blocks' worth of realtime extents,
* as well as the realtime summary block.
*/
-unsigned int
+static unsigned int
xfs_rtalloc_log_count(
struct xfs_mount *mp,
unsigned int num_ops)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static
2019-12-20 9:51 [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static Chen Wandun
@ 2019-12-20 16:30 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-12-20 16:30 UTC (permalink / raw)
To: Chen Wandun; +Cc: linux-xfs, bfoster, dchinner, preichl, sandeen, linux-kernel
On Fri, Dec 20, 2019 at 05:51:57PM +0800, Chen Wandun wrote:
> Fix the following sparse warning:
>
> fs/xfs/libxfs/xfs_trans_resv.c:206:1: warning: symbol 'xfs_rtalloc_log_count' was not declared. Should it be static?
>
> Fixes: b1de6fc7520f ("xfs: fix log reservation overflows when allocating large rt extents")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Urk, oops, good catch!
Especially since the for-next announcement message got totally eaten by
$employer MTA or something. :/
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_trans_resv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
> index 824073a839ac..7a9c04920505 100644
> --- a/fs/xfs/libxfs/xfs_trans_resv.c
> +++ b/fs/xfs/libxfs/xfs_trans_resv.c
> @@ -202,7 +202,7 @@ xfs_calc_inode_chunk_res(
> * blocks as needed to mark inuse MAXEXTLEN blocks' worth of realtime extents,
> * as well as the realtime summary block.
> */
> -unsigned int
> +static unsigned int
> xfs_rtalloc_log_count(
> struct xfs_mount *mp,
> unsigned int num_ops)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-20 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-20 9:51 [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static Chen Wandun
2019-12-20 16:30 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox