From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] libxfs: make resync with the userspace libxfs easier
Date: Tue, 24 Dec 2019 00:29:54 -0800 [thread overview]
Message-ID: <20191224082954.GA20650@infradead.org> (raw)
In-Reply-To: <20191217023535.GA12765@magnolia>
On Mon, Dec 16, 2019 at 06:35:35PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Prepare to resync the userspace libxfs with the kernel libxfs. There
> were a few things I missed -- a couple of static inline directory
> functions that have to be exported for xfs_repair; a couple of directory
> naming functions that make porting much easier if they're /not/ static
> inline; and a u16 usage that should have been uint16_t.
>
> None of these things are bugs in their own right; this just makes
> porting xfsprogs easier.
Instead of exporting random low-level helpers can you please look
into refactoring repair to not require such low level access. E.g.
the put_ino helper seems to be mostly used for convert short form
directories from and to the 8 byte inode format, for which we already
have kernel helpers in a slighty different form.
I'm also kinda pissed that this was rushed into mainline after -rc2
despite not fixing anything in the kernel. That is not how the
development cycle is supposed to work.
next prev parent reply other threads:[~2019-12-24 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 2:35 [PATCH] libxfs: make resync with the userspace libxfs easier Darrick J. Wong
2019-12-18 21:00 ` Eric Sandeen
2019-12-18 21:07 ` Darrick J. Wong
2019-12-24 8:29 ` Christoph Hellwig [this message]
2019-12-24 21:27 ` Darrick J. Wong
2020-01-07 14:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224082954.GA20650@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox