Re: [PATCH v5 06/14] xfs: Factor up trans handling in xfs_attr3_leaf_flipflags

Christoph Hellwig
2019-12-24T12:16:02Z

What does "factor up" mean? Basically this moves the
xfs_trans_roll_inode from xfs_attr3_leaf_flipflags to the callers,
so I'd expect the subject to mention that.

> + /*
> + * Commit the flag value change and start the next trans in
> + * series.
> + */
> + error = xfs_trans_roll_inode(&args->trans, args->dp);

Do we really still need these comments?

> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> index ef96971..4fffa84 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> @@ -2972,10 +2972,5 @@ xfs_attr3_leaf_flipflags(
> XFS_DA_LOGRANGE(leaf2, name_rmt, sizeof(*name_rmt)));
> }
>
> - /*
> - * Commit the flag value change and start the next trans in series.
> - */
> - error = xfs_trans_roll_inode(&args->trans, args->dp);
> -
> return error;

This can become a

return 0;

now.