[PATCH v5 00/14] xfs: Delay Ready Attributes

Allison Collins
2019-12-12T04:17:29Z

Hi all,

This set is a subset of a larger series for delayed attributes. Which
is a subset of an even larger series, parent pointers. Delayed attributes
allow attribute operations (set and remove) to be logged and committed in
the same way that other delayed operations do. This allows more complex
operations (like parent pointers) to be broken up into multiple smaller
transactions. To do this, the existing attr operations must be modified to
operate as either a delayed operation or a inline operation since older
filesystems will not be able to use the new log entries. This means that
they cannot roll, commit, or finish transactions. Instead, they return
EAGAIN an allow the calling function to handle the transaction. In this
series, we focus on only the clean up and refactoring needed to accomplish
this. We will introduce delayed attrs and parent pointers in a later set.

Changes since v4:
Mostly review updates and nits collected since v4. I've added an
xfs_name_init to patch 2 to consolidate some of the initialization. The state
machine is introduced in patch 13 and then expanded as needed 14. I've also
adjusted some of the conditional logic in the delay ready routines such that
we avoid nested gotos.

I've also made the corresponding updates to the user space side, and
xfstests as well.

Questions, comment and feedback appreciated!

Thanks all!
Allison

Allison Collins (12):
xfs: Replace attribute parameters with struct xfs_name
xfs: Embed struct xfs_name in xfs_da_args
xfs: Factor out new helper functions xfs_attr_rmtval_set
xfs: Factor up trans handling in xfs_attr3_leaf_flipflags
xfs: Factor out xfs_attr_leaf_addname helper
xfs: Factor up xfs_attr_try_sf_addname
xfs: Factor up trans roll from xfs_attr3_leaf_setflag
xfs: Factor out xfs_attr_rmtval_invalidate
xfs: Factor up trans roll in xfs_attr3_leaf_clearflag
xfs: Check for -ENOATTR or -EEXIST
xfs: Add delay ready attr remove routines
xfs: Add delay ready attr set routines

Allison Henderson (2):
xfs: Remove all strlen in all xfs_attr_* functions for attr names.
xfs: Add xfs_has_attr and subroutines

fs/xfs/libxfs/xfs_attr.c | 802 ++++++++++++++++++++++++++++------------
fs/xfs/libxfs/xfs_attr.h | 9 +-
fs/xfs/libxfs/xfs_attr_leaf.c | 219 ++++++-----
fs/xfs/libxfs/xfs_attr_leaf.h | 3 +
fs/xfs/libxfs/xfs_attr_remote.c | 103 ++++--
fs/xfs/libxfs/xfs_attr_remote.h | 4 +-
fs/xfs/libxfs/xfs_da_btree.c | 6 +-
fs/xfs/libxfs/xfs_da_btree.h | 33 +-
fs/xfs/libxfs/xfs_dir2.c | 18 +-
fs/xfs/libxfs/xfs_dir2_block.c | 6 +-
fs/xfs/libxfs/xfs_dir2_leaf.c | 6 +-
fs/xfs/libxfs/xfs_dir2_node.c | 8 +-
fs/xfs/libxfs/xfs_dir2_sf.c | 30 +-
fs/xfs/libxfs/xfs_types.c | 10 +
fs/xfs/libxfs/xfs_types.h | 1 +
fs/xfs/scrub/attr.c | 12 +-
fs/xfs/scrub/common.c | 2 +
fs/xfs/xfs_acl.c | 26 +-
fs/xfs/xfs_attr_list.c | 1 +
fs/xfs/xfs_ioctl.c | 18 +-
fs/xfs/xfs_ioctl32.c | 2 +
fs/xfs/xfs_iops.c | 8 +-
fs/xfs/xfs_trace.h | 20 +-
fs/xfs/xfs_xattr.c | 21 +-
24 files changed, 918 insertions(+), 450 deletions(-)

--
2.7.4