Re: [PATCH v5 05/14] xfs: Factor out new helper functions xfs_attr_rmtval_set

Christoph Hellwig
2019-12-24T12:14:11Z

On Wed, Dec 11, 2019 at 09:15:04PM -0700, Allison Collins wrote:
> Break xfs_attr_rmtval_set into two helper functions
> xfs_attr_rmt_find_hole and xfs_attr_rmtval_set_value.
> xfs_attr_rmtval_set rolls the transaction between the
> helpers, but delayed operations cannot. We will use
> the helpers later when constructing new delayed
> attribute routines.

Please use up the foll 72-ish characters for the changelog (also for
various other patches).

For the actual patch: can you keep the code in the order of the calling
conventions, that is the lower level functions up and
xfs_attr_rmtval_set at the bottom? Also please keep the functions
static until callers show up (which nicely leads to the above order).