Re: [PATCH] libxfs: make resync with the userspace libxfs easier

[Christoph Hellwig <hch@infradead.org>]

On Tue, Dec 24, 2019 at 01:27:24PM -0800, Darrick J. Wong wrote:
> > Instead of exporting random low-level helpers can you please look
> > into refactoring repair to not require such low level access.  E.g.
> > the put_ino helper seems to be mostly used for convert short form
> > directories from and to the 8 byte inode format, for which we already
> > have kernel helpers in a slighty different form.
> 
> We do?  I didn't find /any/ helpers to fix shortform inums and ftype.
> xfs_repair directly manipulates a lot of directory structures directly
> with libxfs functions.

We have helpers to convert between the 4 and 7 byte ino sf format,
which sounds like something that should be reused.

> So anyway, I am sorry for ruffling your feathers.  I am particularly bad
> at handling small cleanups to smooth over xfsprogs when reviewers are
> short.

What really annoys me is not that patch - it is worth a discussion.
The problem is that you rushed it into -rc against the merge window
rules before we could even have a discussion.