From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "yukuai (C)" <yukuai3@huawei.com>
Cc: bfoster@redhat.com, dchinner@redhat.com, sandeen@sandeen.net,
cmaiolino@redhat.com, hch@lst.de, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, zhengbin13@huawei.com,
yi.zhang@huawei.com, houtao1@huawei.com
Subject: Re: [PATCH 2/2] xfs: fix stale data exposure problem when punch hole, collapse range or zero range across a delalloc extent
Date: Tue, 7 Jan 2020 10:17:51 -0800 [thread overview]
Message-ID: <20200107181751.GB917713@magnolia> (raw)
In-Reply-To: <f4bf9490-0476-3a6a-55e0-786186669c6c@huawei.com>
On Tue, Jan 07, 2020 at 10:09:44AM +0800, yukuai (C) wrote:
>
>
> On 2020/1/7 5:57, Darrick J. Wong wrote:
> > So your solution is to split the delalloc reservation to constrain the
> > allocation to the range that's being operated on?
> Yes, I'm trying to split delalloc reservation.
> >
> > If so, I think a better solution (at least from the perspective of
> > reducing fragmentation) would be to map the extent unwritten and force a
> > post-writeback conversion[1] but I got shot down for performance reasons
> > the last time I suggested that.
> I'm wondering if spliting delalloc reservation have the same performance
> issue.
Probably not, but OTOH will doing so (a) have a noticeable effect on
fragmentation, and (b) will the kernel code choke on two adjacent
delalloc extents that could be merged? (I think the answer is no since
we'll either complete the operation or the fs goes down...?)
--D
> Thanks!
> Yu Kuai
>
prev parent reply other threads:[~2020-01-07 18:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 13:47 [PATCH 0/2] fix stale data exposure problem yu kuai
2019-12-26 13:47 ` [PATCH 1/2] xfs: introduce xfs_bmap_split_da_extent yu kuai
2020-01-05 21:04 ` Dave Chinner
2019-12-26 13:47 ` [PATCH 2/2] xfs: fix stale data exposure problem when punch hole, collapse range or zero range across a delalloc extent yu kuai
2019-12-27 0:17 ` kbuild test robot
2019-12-27 0:17 ` [RFC PATCH] xfs: try_split_da_extent can be static kbuild test robot
2019-12-27 14:25 ` [xfs] 1c6c6a28e3: Assertion_failed kernel test robot
2020-01-06 21:57 ` [PATCH 2/2] xfs: fix stale data exposure problem when punch hole, collapse range or zero range across a delalloc extent Darrick J. Wong
2020-01-07 2:09 ` yukuai (C)
2020-01-07 18:17 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107181751.GB917713@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox