From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>
Subject: Re: [PATCH 1/1] xfs: remove bogus assertion when online repair isn't enabled
Date: Wed, 8 Jan 2020 00:13:25 -0800 [thread overview]
Message-ID: <20200108081325.GD25201@infradead.org> (raw)
In-Reply-To: <157845707964.83042.11399554567794736343.stgit@magnolia>
On Tue, Jan 07, 2020 at 08:17:59PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> We don't need to assert on !REPAIR in the stub version of
> xrep_calc_ag_resblks that is called when online repair hasn't been
> compiled into the kernel because none of the repair code will ever run.
>
> Reported-by: Eryu Guan <guaneryu@gmail.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-01-08 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 4:17 [PATCH 0/1] xfs: random fixes Darrick J. Wong
2020-01-08 4:17 ` [PATCH 1/1] xfs: remove bogus assertion when online repair isn't enabled Darrick J. Wong
2020-01-08 8:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108081325.GD25201@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox