From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH v2 3/7] xfs: streamline xfs_attr3_leaf_inactive
Date: Wed, 15 Jan 2020 23:48:08 -0800 [thread overview]
Message-ID: <20200116074808.GA18683@infradead.org> (raw)
In-Reply-To: <20200116014744.GE8247@magnolia>
On Wed, Jan 15, 2020 at 05:47:44PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Now that we know we don't have to take a transaction to stale the incore
> buffers for a remote value, get rid of the unnecessary memory allocation
> in the leaf walker and call the rmt_stale function directly. Flatten
> the loop while we're at it.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-01-16 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 17:02 [PATCH v4 0/7] xfs: fix buf log item memory corruption on non-amd64 Darrick J. Wong
2020-01-15 17:02 ` [PATCH 1/7] xfs: refactor remote attr value buffer invalidation Darrick J. Wong
2020-01-15 17:03 ` [PATCH 2/7] xfs: fix memory corruption during " Darrick J. Wong
2020-01-15 19:10 ` Christoph Hellwig
2020-01-15 17:03 ` [PATCH 3/7] xfs: streamline xfs_attr3_leaf_inactive Darrick J. Wong
2020-01-15 19:14 ` Christoph Hellwig
2020-01-16 1:47 ` [PATCH v2 " Darrick J. Wong
2020-01-16 7:48 ` Christoph Hellwig [this message]
2020-01-15 17:03 ` [PATCH 4/7] xfs: clean up xfs_buf_item_get_format return value Darrick J. Wong
2020-01-15 17:03 ` [PATCH 5/7] xfs: complain if anyone tries to create a too-large buffer log item Darrick J. Wong
2020-01-15 17:03 ` [PATCH 6/7] xfs: make struct xfs_buf_log_format have a consistent size Darrick J. Wong
2020-01-15 17:03 ` [PATCH 7/7] xfs: check log iovec size to make sure it's plausibly a buffer log format Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116074808.GA18683@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox