Re: [PATCH 02/29] xfs: merge xfs_attr_remove into xfs_attr_set

Darrick J. Wong
2020-01-26T22:24:04Z

On Sat, Jan 25, 2020 at 03:22:59PM -0800, Christoph Hellwig wrote:
> On Fri, Jan 24, 2020 at 09:17:15PM -0700, Allison Collins wrote:
>
> [full quote deleted, please follow proper mail netiquette]
>
> > > (The first thing my brain thought was, "ENOATTR on a set operation
> > > suggests to me that something's seriously broken in the attr code; why
> > > would you mask it?")
> > >
> > > --D
> >
> > Would either of you mind if I were to pick up this patch and make a mini set
> > that resolves some of the overlap between our sets? I'll fix the nits here.
> > Let me know, thanks!
>
> I'd rather resend the whole thing - it fixes various issues with the
> attr flags handling and removes lots of codes. I'll try to do so today,
> but Darrick can decide if he just wants to pick parts if that makes life
> easier.

/me would sort of like to keep the whole set together, but I'm pretty
sure we're out of time for 5.6, so ... if there are any patches that are
straight bugfixes, please flag them as such when you resend.

--D