Re: [PATCH 09/29] xfs: turn xfs_da_args.value into a void pointer

Christoph Hellwig
2020-01-23T22:36:51Z

On Tue, Jan 21, 2020 at 10:07:42AM -0800, Darrick J. Wong wrote:
> On Tue, Jan 14, 2020 at 09:10:31AM +0100, Christoph Hellwig wrote:
> > The xattr values are blobs and should not be typed.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> /me wonders if it's worth using a union for filetype vs. value/valuelen
> to save a few padding bytes, but that's another patch...

If we want to go down that route it might make sense to have an
xfs_attr_args and xfs_dir2_args, which both embedd the da_args. But not
for now..