From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] xfs_repair: stop using ->data_entry_p()
Date: Mon, 20 Jan 2020 00:58:09 -0800 [thread overview]
Message-ID: <20200120085809.GA22525@infradead.org> (raw)
In-Reply-To: <2cf1f45b-b3b2-f630-50d5-ff34c000b0c8@redhat.com>
On Fri, Jan 17, 2020 at 05:17:11PM -0600, Eric Sandeen wrote:
> The ->data_entry_p() op went away in v5.5 kernelspace, so rework
> xfs_repair to use ->data_entry_offset instead, in preparation
> for the v5.5 libxfs backport.
>
> This could later be cleaned up to use offsets as was done
> in kernel commit 8073af5153c for example.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> I'll munge this patch in mid-libxfs-sync, just before the
> ->data_entry_p removal patch.
Looks good, and I can give the cleanup a try once I find a little time.
prev parent reply other threads:[~2020-01-20 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 23:17 [PATCH] xfs_repair: stop using ->data_entry_p() Eric Sandeen
2020-01-18 4:39 ` Darrick J. Wong
2020-01-20 14:29 ` Eric Sandeen
2020-01-21 18:37 ` Darrick J. Wong
2020-01-22 0:41 ` Darrick J. Wong
2020-01-20 8:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120085809.GA22525@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox