Re: [PATCH 09/29] xfs: turn xfs_da_args.value into a void pointer

Darrick J. Wong
2020-01-21T18:07:50Z

On Tue, Jan 14, 2020 at 09:10:31AM +0100, Christoph Hellwig wrote:
> The xattr values are blobs and should not be typed.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

/me wonders if it's worth using a union for filetype vs. value/valuelen
to save a few padding bytes, but that's another patch...

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/xfs/libxfs/xfs_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_types.h b/fs/xfs/libxfs/xfs_types.h
> index e2711d119665..634814dd1d10 100644
> --- a/fs/xfs/libxfs/xfs_types.h
> +++ b/fs/xfs/libxfs/xfs_types.h
> @@ -192,7 +192,7 @@ typedef struct xfs_da_args {
> const uint8_t *name; /* string (maybe not NULL terminated) */
> int namelen; /* length of string (maybe no NULL) */
> uint8_t filetype; /* filetype of inode for directories */
> - uint8_t *value; /* set of bytes (maybe contain NULLs) */
> + void *value; /* set of bytes (maybe contain NULLs) */
> int valuelen; /* length of value */
> int flags; /* argument flags (eg: ATTR_NOCREATE) */
> xfs_dahash_t hashval; /* hash value of name */
> --
> 2.24.1
>