Re: [PATCH 05/29] xfs: factor out a helper for a single XFS_IOC_ATTRMULTI_BY_HANDLE op

Christoph Hellwig
2020-01-23T22:34:58Z

On Tue, Jan 21, 2020 at 09:54:53AM -0800, Darrick J. Wong wrote:
> >
> > +int
> > +xfs_ioc_attrmulti_one(
> > + struct file *parfilp,
> > + struct inode *inode,
> > + uint32_t opcode,
> > + void __user *uname,
> > + void __user *value,
> > + uint32_t *len,
> > + uint32_t flags)
>
> That's a lot of arguments. Any chance you could change the ioctl32
> handler to convert the compat_xfs_attr_multiop to a xfs_attr_multiop and
> pass that into this function?

We could, but it would be painful. The interface also isn't really
that different from the normal xattr one, so I don't find it too bad.