From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 2/2 V2] xfs: don't take addresses of packed xfs_rmap_key member
Date: Wed, 29 Jan 2020 10:29:36 -0800 [thread overview]
Message-ID: <20200129182936.GE14855@infradead.org> (raw)
In-Reply-To: <b44b9c6e-4c40-2670-8c38-874a79e0d066@redhat.com>
On Wed, Jan 29, 2020 at 12:15:06PM -0600, Eric Sandeen wrote:
> {
> uint64_t off;
> + xfs_agblock_t start;
> int adj;
>
> adj = be32_to_cpu(rec->rmap.rm_blockcount) - 1;
>
> key->rmap.rm_startblock = rec->rmap.rm_startblock;
> - be32_add_cpu(&key->rmap.rm_startblock, adj);
> + start = be32_to_cpu(key->rmap.rm_startblock) - adj;
> + key->rmap.rm_startblock = cpu_to_be32(start);
Do we really need the local variable? Why not:
key->rmap.rm_startblock =
cpu_to_be32(be32_to_cpu(key->rmap.rm_startblock) - adj);
next prev parent reply other threads:[~2020-01-29 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 17:41 [PATCH 0/2] xfs: don't take addresses of packed structures Eric Sandeen
2020-01-29 17:43 ` [PATCH 1/2] xfs: don't take addresses of packed xfs_agfl_t member Eric Sandeen
2020-01-29 18:09 ` Christoph Hellwig
2020-01-29 18:18 ` Eric Sandeen
2020-01-29 18:28 ` Christoph Hellwig
2020-01-29 18:46 ` Eric Sandeen
2020-01-29 17:45 ` [PATCH 2/2] xfs: don't take addresses of packed xfs_rmap_key Eric Sandeen
2020-01-29 17:56 ` Darrick J. Wong
2020-01-29 18:01 ` Eric Sandeen
2020-01-29 18:15 ` [PATCH 2/2 V2] xfs: don't take addresses of packed xfs_rmap_key member Eric Sandeen
2020-01-29 18:29 ` Christoph Hellwig [this message]
2020-01-29 18:31 ` Eric Sandeen
2020-01-29 18:35 ` [PATCH 2/2 V3] " Eric Sandeen
2020-01-29 18:36 ` Christoph Hellwig
2020-02-26 18:06 ` Darrick J. Wong
2020-02-26 18:21 ` Eric Sandeen
2020-02-26 18:45 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129182936.GE14855@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox