From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH V3] xfsprogs: do not redeclare globals provided by libraries
Date: Wed, 29 Jan 2020 13:32:19 -0800 [thread overview]
Message-ID: <20200129213219.GA16593@infradead.org> (raw)
In-Reply-To: <db48723d-10dd-a86d-b623-58befde5961e@sandeen.net>
On Wed, Jan 29, 2020 at 01:47:49PM -0600, Eric Sandeen wrote:
> V3: ditto, plus enforce -fno-common so older gcc users will play
> by the same rules as gcc 10
I don't mind adding -fno-common, but it has aboslutely nothing to do
with removing pointless duplicate variable defintions.
I'd say apply v2 and make this a separate patch.
> @@ -13,7 +13,7 @@ OPTIMIZER = @opt_build@
> MALLOCLIB = @malloc_lib@
> LOADERFLAGS = @LDFLAGS@
> LTLDFLAGS = @LDFLAGS@
> -CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64
> +CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64 -fno-common
Are there any compilers not supporting -fno-common? (And do we care?)
next prev parent reply other threads:[~2020-01-29 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 22:56 [PATCH] xfsprogs: do not redeclare globals provided by libraries Eric Sandeen
2020-01-28 3:29 ` Darrick J. Wong
2020-01-28 14:48 ` Eric Sandeen
2020-01-28 22:26 ` Dave Chinner
2020-01-28 22:28 ` Eric Sandeen
2020-01-28 19:42 ` Eric Sandeen
2020-01-29 15:16 ` [PATCH V2] " Eric Sandeen
2020-01-29 16:01 ` Darrick J. Wong
2020-01-29 16:57 ` Eric Sandeen
2020-01-29 19:29 ` Darrick J. Wong
2020-01-29 18:06 ` Christoph Hellwig
2020-01-29 19:47 ` [PATCH V3] " Eric Sandeen
2020-01-29 21:32 ` Christoph Hellwig [this message]
2020-01-29 22:20 ` Eric Sandeen
2020-01-29 18:05 ` [PATCH] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129213219.GA16593@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox