Re: [PATCH 10/8] libxfs: remove duplicate attr function declarations

Eric Sandeen
2020-01-30T18:48:46Z

On 1/30/20 12:40 PM, Darrick J. Wong wrote:
> On Thu, Jan 30, 2020 at 12:28:43PM -0600, Eric Sandeen wrote:
>> On 1/30/20 12:13 PM, Darrick J. Wong wrote:
>>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>>
>>> Remove these function declarations since they're in libxfs/xfs_attr.h
>>> and are therefore redundant.
>>>
>>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>>
>> Is it worth keeping this exporting hack around to make static checkers
>> happy if it's just one more thing to keep up to date in userspace?
>
> Probably? It depends on how much you like culling known false positives
> when you run smatch/sparse against xfsprogs.
>
> (I for one don't mind not having to remember that stuff...)

Ok. I'm wondering how you guys happened to notice the dups.

Seems like

bool xfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);

can be removed as well, FWIW.

-Eric