Re: [PATCH 10/8] libxfs: remove duplicate attr function declarations

Darrick J. Wong
2020-01-30T18:54:29Z

On Thu, Jan 30, 2020 at 12:28:43PM -0600, Eric Sandeen wrote:
> On 1/30/20 12:13 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Remove these function declarations since they're in libxfs/xfs_attr.h
> > and are therefore redundant.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Is it worth keeping this exporting hack around to make static checkers
> happy if it's just one more thing to keep up to date in userspace?

Probably? It depends on how much you like culling known false positives
when you run smatch/sparse against xfsprogs.

(I for one don't mind not having to remember that stuff...)

--D

> -Eric