Re: [PATCH v3 06/12] fs/xfs: Check if the inode supports DAX under lock

Ira Weiny
2020-02-12T16:10:48Z

On Wed, Feb 12, 2020 at 07:42:20AM +1100, Dave Chinner wrote:
> On Tue, Feb 11, 2020 at 09:55:09AM -0800, Ira Weiny wrote:
> > On Tue, Feb 11, 2020 at 05:16:39PM +1100, Dave Chinner wrote:
> > > On Sat, Feb 08, 2020 at 11:34:39AM -0800, ira.weiny@intel.com wrote:
> > > > From: Ira Weiny <ira.weiny@intel.com>
> > > >

[snip]

> > >
> > > This raciness in checking the DAX flags is the reason that
> > > xfs_ioctl_setattr_xflags() redoes all the reflink vs dax checks once
> > > it's called under the XFS_ILOCK_EXCL during the actual change
> > > transaction....
> >
> > Ok I found this by trying to make sure that the xfs_inode_supports_dax() call
> > was always returning valid data. So I don't have a specific test which was
> > failing.
> >
> > Looking at the code again, it sounds like I was wrong about which locks protect
> > what and with your explanation above it looks like there is nothing to be done
> > here and I can drop the patch.
> >
> > Would you agree?
>
> *nod*

Thanks! done.
Ira

>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com