Re: [PATCH v3 04/12] fs/xfs: Clean up DAX support check

Ira Weiny
2020-02-11T16:28:33Z

On Tue, Feb 11, 2020 at 04:57:45PM +1100, Dave Chinner wrote:
> On Sat, Feb 08, 2020 at 11:34:37AM -0800, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Rather than open coding xfs_inode_supports_dax() in
> > xfs_ioctl_setattr_dax_invalidate() export xfs_inode_supports_dax() and
> > call it in preparation for swapping dax flags.
> >
> > This also means updating xfs_inode_supports_dax() to return true for a
> > directory.
>
> That's not correct. This now means S_DAX gets set on directory inodes
> because both xfs_inode_supports_dax() and the on-disk inode flag
> checks return true in xfs_diflags_to_iflags(). Hence when we
> instantiate a directory inode with a DAX inherit hint set on it
> we'll set S_DAX on the inode and so IS_DAX() will return true for
> directory inodes...

I'm not following. Don't we want S_DAX to get set on directory inodes?

IIRC what we wanted was something like this where IS_DAX is the current state
and "dax" is the inode flag:

/ <IS_DAX=0 dax=0>
dir1 <IS_DAX=0 dax=0>
f0 <IS_DAX=0 dax=0>
f1 <IS_DAX=1 dax=1>
dir2 <IS_DAX=1 dax=1>
f2 <IS_DAX=1 dax=1>
f3 <IS_DAX=0 dax=0>
dir3 <IS_DAX=1 dax=1>
f4 <IS_DAX=1 dax=1>
dir4 <IS_DAX=0 dax=0>
f5 <IS_DAX=0 dax=0>
f6 <IS_DAX=1 dax=1>

Where f1, dir2, f3, and dir4 required explicit state changes when they were
created. Because they inherited their dax state from the parent. All the
other creations happened based on the DAX state of the parent directory. So we
need to store and know the state of the directories. What am I missing?

Ira

>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com