From: Dave Chinner <david@fromorbit.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v4 3/4] xfs: Fix bug when checking diff. locks
Date: Wed, 12 Feb 2020 11:38:21 +1100 [thread overview]
Message-ID: <20200212003821.GQ10776@dread.disaster.area> (raw)
In-Reply-To: <20200211221018.709125-3-preichl@redhat.com>
On Tue, Feb 11, 2020 at 11:10:17PM +0100, Pavel Reichl wrote:
> In its current form, xfs_isilocked() is only able to test one lock type at a
> time - ilock, iolock, or mmap lock, but combinations are not properly handled.
> The intent here is to check that both XFS_IOLOCK_EXCL and XFS_ILOCK_EXCL are
> held, so test them each separately.
>
> The commit ecfea3f0c8c6 ("xfs: split xfs_bmap_shift_extents") ORed the flags
> together which was an error, so this patch reverts that part of the change and
> check the locks independently.
Commit message should wrap at 68-72 columns.
> Fixes: ecfea3f0c8c6 ("xfs: split xfs_bmap_shift_extents")
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Suggested-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> ---
> Changelog from V3:
> Commit message extened.
Same comment as the previous patch about the subject - "fix" and
abbreviations.
xfs: xfs_isilocked() can only check a single lock type
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-02-12 0:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 22:10 [PATCH v4 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-02-11 22:10 ` [PATCH v4 2/4] xfs: Fix WS in xfs_isilocked() calls Pavel Reichl
2020-02-12 0:35 ` Dave Chinner
2020-02-11 22:10 ` [PATCH v4 3/4] xfs: Fix bug when checking diff. locks Pavel Reichl
2020-02-12 0:38 ` Dave Chinner [this message]
2020-02-11 22:10 ` [PATCH v4 4/4] xfs: Replace mrlock_t by rw_semaphore Pavel Reichl
2020-02-12 0:49 ` Dave Chinner
2020-02-11 22:27 ` [PATCH v4 1/4] xfs: Refactor xfs_isilocked() Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212003821.GQ10776@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox