Re: [PATCH 01/12] mm: fix a comment in sys_swapon

Christoph Hellwig
2020-02-12T07:37:24Z

On Mon, Feb 10, 2020 at 03:29:42PM -0800, Andrew Morton wrote:
> On Tue, 14 Jan 2020 17:12:14 +0100 Christoph Hellwig <hch@lst.de> wrote:
>
> > claim_swapfile now always takes i_rwsem.
> >
> > ...
> >
> > --- a/mm/swapfile.c
> > +++ b/mm/swapfile.c
> > @@ -3157,7 +3157,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
> > mapping = swap_file->f_mapping;
> > inode = mapping->host;
> >
> > - /* If S_ISREG(inode->i_mode) will do inode_lock(inode); */
> > + /* will take i_rwsem; */
> > error = claim_swapfile(p, inode);
> > if (unlikely(error))
> > goto bad_swap;
>
> http://lkml.kernel.org/r/20200206090132.154869-1-naohiro.aota@wdc.com
> removes this comment altogether. Please check that this is OK?

Killing it is fine with me. Just the fact that the comment was wrong
while I did an audit of the area really thew me off.