From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4EF9C2BA83 for ; Wed, 12 Feb 2020 15:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A97D520873 for ; Wed, 12 Feb 2020 15:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LMTuT+MV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727458AbgBLP5E (ORCPT ); Wed, 12 Feb 2020 10:57:04 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:56559 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727026AbgBLP5E (ORCPT ); Wed, 12 Feb 2020 10:57:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581523023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/mHK3YoSevia1D/vDXY6uwwCKZDuhlBb7bpDu4SpKnY=; b=LMTuT+MVGqPoxEbyDtxX6EdMhuD7SBokRyg0izSEN6Pmms5okDTSbH+/3zBWxjZyuKLVXZ F/oFAWb/lTkiwa1Wz+KcxBmosjH3XYruHWWwihhDViGoAif5k7kUA6BaMBAig8++0QpI6U fXTbEG6vlxptm0hTKgCjQmMJymPIcFI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-zjWJLb-pPjubDPGdVQXrYQ-1; Wed, 12 Feb 2020 10:55:13 -0500 X-MC-Unique: zjWJLb-pPjubDPGdVQXrYQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B01C510054E3; Wed, 12 Feb 2020 15:55:12 +0000 (UTC) Received: from bfoster (dhcp-41-2.bos.redhat.com [10.18.41.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5681B5C1B2; Wed, 12 Feb 2020 15:55:12 +0000 (UTC) Date: Wed, 12 Feb 2020 10:55:10 -0500 From: Brian Foster To: bugzilla-daemon@bugzilla.kernel.org Cc: linux-xfs@vger.kernel.org Subject: Re: [Bug 206397] [xfstests generic/475] XFS: Assertion failed: iclog->ic_state == XLOG_STATE_ACTIVE, file: fs/xfs/xfs_log.c, line: 572 Message-ID: <20200212155510.GC17921@bfoster> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Feb 04, 2020 at 05:10:05PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=206397 > > --- Comment #2 from Zorro Lang (zlang@redhat.com) --- > (In reply to Chandan Rajendra from comment #1) > > I was unable to recreate this issue on a ppc64le kvm guest. I used Linux > > v5.5 and xfsprogs' for-next branch. > > > > Can you please share the kernel config file? Also, Can you please tell me > > how easy is it recreate this bug? > > It's really hard to reproduce. The g/475 is a random test, it's helped us to > find many different issues. For this bug, this's the 1st time I hit it, and > can't reproduce it simply. > Have you still been unable to reproduce (assuming you've been attempting to)? How many iterations were required before you reproduced the first time? I'm wondering if the XLOG_STATE_IOERROR check in xfs_log_release_iclog() is racy with respect to filesystem shutdown. There's an ASSERT_ALWAYS() earlier in this (xlog_cil_push()) codepath that checks for ACTIVE || WANT_SYNC and it doesn't appear that has failed from your output snippet. The aforementioned IOERROR check occurs before we acquire ->l_icloglock, however, which I think means xfs_log_force_umount() could jump in if called from another task and reset all of the iclogs while the release path waits on the lock. Brian > -- > You are receiving this mail because: > You are watching the assignee of the bug. >