From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D56C34022 for ; Mon, 17 Feb 2020 23:26:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 038D420836 for ; Mon, 17 Feb 2020 23:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725997AbgBQX0A (ORCPT ); Mon, 17 Feb 2020 18:26:00 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:59598 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbgBQX0A (ORCPT ); Mon, 17 Feb 2020 18:26:00 -0500 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 2A58B3A1E98; Tue, 18 Feb 2020 10:25:57 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j3pm0-0003tb-Lu; Tue, 18 Feb 2020 10:25:56 +1100 Date: Tue, 18 Feb 2020 10:25:56 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Allison Collins , "Darrick J . Wong" Subject: Re: [PATCH 19/31] xfs: remove the unused ATTR_ENTRY macro Message-ID: <20200217232556.GT10776@dread.disaster.area> References: <20200217125957.263434-1-hch@lst.de> <20200217125957.263434-20-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217125957.263434-20-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=Ikylat1uBDQ_IfeLlMQA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Feb 17, 2020 at 01:59:45PM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > Reviewed-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_attr.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h > index 0c8f7c7a6b65..31c0ffde4f59 100644 > --- a/fs/xfs/libxfs/xfs_attr.h > +++ b/fs/xfs/libxfs/xfs_attr.h > @@ -69,14 +69,6 @@ typedef struct attrlist_ent { /* data from attr_list() */ > char a_name[1]; /* attr name (NULL terminated) */ > } attrlist_ent_t; > > -/* > - * Given a pointer to the (char*) buffer containing the attr_list() result, > - * and an index, return a pointer to the indicated attribute in the buffer. > - */ > -#define ATTR_ENTRY(buffer, index) \ > - ((attrlist_ent_t *) \ > - &((char *)buffer)[ ((attrlist_t *)(buffer))->al_offset[index] ]) > - > /* > * Kernel-internal version of the attrlist cursor. > */ I'm surprised it lasted this long. :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com