From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD42DC34042 for ; Tue, 18 Feb 2020 15:30:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A13F321D56 for ; Tue, 18 Feb 2020 15:30:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgBRPaa (ORCPT ); Tue, 18 Feb 2020 10:30:30 -0500 Received: from verein.lst.de ([213.95.11.211]:38736 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbgBRPaa (ORCPT ); Tue, 18 Feb 2020 10:30:30 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 3E04F68BE1; Tue, 18 Feb 2020 16:30:27 +0100 (CET) Date: Tue, 18 Feb 2020 16:30:27 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, Allison Collins , Chandan Rajendra , "Darrick J . Wong" Subject: Re: [PATCH 13/31] xfs: remove the xfs_inode argument to xfs_attr_get_ilocked Message-ID: <20200218153026.GD21275@lst.de> References: <20200217125957.263434-1-hch@lst.de> <20200217125957.263434-14-hch@lst.de> <20200217230608.GN10776@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217230608.GN10776@dread.disaster.area> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Feb 18, 2020 at 10:06:08AM +1100, Dave Chinner wrote: > > lock_mode = xfs_ilock_attr_map_shared(args->dp); > > - error = xfs_attr_get_ilocked(args->dp, args); > > + error = xfs_attr_get_ilocked(args); > > xfs_iunlock(args->dp, lock_mode); > > ... at this point I really would like to see the "args->dp" pointer > get renamed. "dp" was originally short for "directory inode > pointer", but it's clear that it hasn't meant that for a long time. > It's just an inode pointer. > > That's out of scope for this patch set, though, so maybe the next > cleanup patchset? That's for another time. And while I found the dp naming rather odd I'm not sure it really is worth the churn on its own. That being said the da_args structure really needs to be split into dir and attr args, as those can be almost entirely separate anyway.