From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D87C34026 for ; Tue, 18 Feb 2020 15:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53B2C2176D for ; Tue, 18 Feb 2020 15:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbgBRPib (ORCPT ); Tue, 18 Feb 2020 10:38:31 -0500 Received: from verein.lst.de ([213.95.11.211]:38766 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726557AbgBRPib (ORCPT ); Tue, 18 Feb 2020 10:38:31 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 14AC868BE1; Tue, 18 Feb 2020 16:38:28 +0100 (CET) Date: Tue, 18 Feb 2020 16:38:27 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, Allison Collins , Chandan Rajendra Subject: Re: [PATCH 21/31] xfs: move the legacy xfs_attr_list to xfs_ioctl.c Message-ID: <20200218153827.GA21780@lst.de> References: <20200217125957.263434-1-hch@lst.de> <20200217125957.263434-22-hch@lst.de> <20200217234136.GV10776@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217234136.GV10776@dread.disaster.area> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Feb 18, 2020 at 10:41:36AM +1100, Dave Chinner wrote: > On Mon, Feb 17, 2020 at 01:59:47PM +0100, Christoph Hellwig wrote: > > The old xfs_attr_list code is only used by the attrlist by handle > > ioctl. Move it to xfs_ioctl.c with its user. Also move the > > attrlist and attrlist_ent structure to xfs_fs.h, as they are exposed > > user ABIs. They are used through libattr headers with the same name > > by at least xfsdump. Also document this relation so that it doesn't > > require a research project to figure out. > > That's a bit nasty. I suspect that also needs documentation in the > path_to_handle(3) man page, too. Probably. > > + /* > > + * Initialize the output buffer. > > + */ > > + memset(&context, 0, sizeof(context)); > > + context.dp = dp; > > + context.cursor = cursor; > > + context.resynch = 1; > > + context.flags = flags; > > + context.buffer = buffer; > > + context.bufsize = (bufsize & ~(sizeof(int)-1)); /* align */ > > ALIGN()? Isn't round_down the macro to use here? I'll add another patch to the end of the series for that.