Re: [PATCH v6 14/19] ext4: Convert from readpages to readahead

Eric Biggers
2020-02-19T03:29:37Z

On Mon, Feb 17, 2020 at 10:46:05AM -0800, Matthew Wilcox wrote:
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index c1769afbf799..e14841ade612 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -7,8 +7,8 @@
> *
> * This was originally taken from fs/mpage.c
> *
> - * The intent is the ext4_mpage_readpages() function here is intended
> - * to replace mpage_readpages() in the general case, not just for
> + * The ext4_mpage_readahead() function here is intended to
> + * replace mpage_readahead() in the general case, not just for
> * encrypted files. It has some limitations (see below), where it
> * will fall back to read_block_full_page(), but these limitations
> * should only be hit when page_size != block_size.
> @@ -222,8 +222,7 @@ static inline loff_t ext4_readpage_limit(struct inode *inode)
> }

This says ext4_mpage_readahead(), but it's actually still called
ext4_mpage_readpages().

- Eric