From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] libxfs: return flush failures
Date: Tue, 18 Feb 2020 20:39:10 -0800 [thread overview]
Message-ID: <20200219043910.GJ9506@magnolia> (raw)
In-Reply-To: <20200217140023.GN18371@infradead.org>
On Mon, Feb 17, 2020 at 06:00:23AM -0800, Christoph Hellwig wrote:
> On Tue, Feb 04, 2020 at 04:47:43PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Modify platform_flush_device so that we can return error status when
> > device flushes fail.
>
> The change itself looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> But the existing logic in platform_flush_device looks suspicious.
> Even on a block device fsync is usually the right thing, so we
> should unconditionally do that first. The BLKFLSBUF ioctl does some
> rather weird things which I'm not sure we really want here, but if we
> do I'd rather see if after we've flushed out the actual data..
BLKFLSBUF flushes the data and then shoots down the page cache, right?
That's certainly odd, but I think (at least as far as old kernels go) we
aren't actively losing data.
However, I agree that we should fsync() files and block devices equally.
--D
next prev parent reply other threads:[~2020-02-19 4:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 0:47 [PATCH 0/4] libxfs: actually check that writes succeeded Darrick J. Wong
2020-02-05 0:47 ` [PATCH 1/4] libxfs: libxfs_buf_delwri_submit should write buffers immediately Darrick J. Wong
2020-02-06 19:37 ` Allison Collins
2020-02-17 13:57 ` Christoph Hellwig
2020-02-19 5:42 ` Darrick J. Wong
2020-02-05 0:47 ` [PATCH 2/4] libxfs: complain when write IOs fail Darrick J. Wong
2020-02-06 19:38 ` Allison Collins
2020-02-17 13:57 ` Christoph Hellwig
2020-02-05 0:47 ` [PATCH 3/4] libxfs: return flush failures Darrick J. Wong
2020-02-06 19:38 ` Allison Collins
2020-02-19 4:38 ` Darrick J. Wong
2020-02-17 14:00 ` Christoph Hellwig
2020-02-19 4:39 ` Darrick J. Wong [this message]
2020-02-05 0:47 ` [PATCH 4/4] misc: make all tools check that metadata updates have been committed Darrick J. Wong
2020-02-06 19:38 ` Allison Collins
2020-02-19 5:42 ` Darrick J. Wong
2020-02-17 14:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219043910.GJ9506@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).