From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove the di_version field from struct icdinode
Date: Wed, 19 Feb 2020 19:45:19 +0100 [thread overview]
Message-ID: <20200219184519.GB22307@lst.de> (raw)
In-Reply-To: <20200219145234.GE24157@bfoster>
On Wed, Feb 19, 2020 at 09:52:34AM -0500, Brian Foster wrote:
> FWIW, I don't really view this patch as a straightforward
> simplification. IMO, this slightly sacrifices readability for slightly
> less code and a smaller xfs_icdinode. That might be acceptable... I
I actually find it easier to read. The per-inode versioning seems
to suggest inodes could actually be different on the same fs, while
the new one makes it clear that all inodes on the fs are the same.
> don't feel terribly strongly against it, but to me the explicit version
> checks are more clear in cases where the _hascrc() check is not used for
> something that is obviously CRC related (which is a pattern I'm
> generally not a fan of).
xfs_sb_version_hascrc is rather misnamed unfortunately. In fact I think
just open coding it as 'XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5'
would improve things quite a bit.
next prev parent reply other threads:[~2020-02-19 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 10:46 [PATCH] xfs: remove the di_version field from struct icdinode Christoph Hellwig
2020-02-18 21:06 ` Christoph Hellwig
2020-02-19 0:18 ` Darrick J. Wong
2020-02-19 14:52 ` Brian Foster
2020-02-19 18:45 ` Christoph Hellwig [this message]
2020-02-19 19:21 ` Brian Foster
2020-02-19 21:47 ` Darrick J. Wong
2020-02-19 18:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219184519.GB22307@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).