Re: [PATCH 07/18] libxfs: make libxfs_bwrite do what libxfs_writebufr does

Christoph Hellwig
2020-02-21T14:45:49Z

On Wed, Feb 19, 2020 at 05:43:19PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Make libxfs_bwrite equivalent to libxfs_writebufr. This makes it so
> that libxfs bwrite calls write the buffer to disk immediately and
> without double-freeing the buffer. However, we choose to consolidate
> around the libxfs_bwrite name to match the kernel.

The commit message looks a little odd. Also why is the subject a
different style than the previous messages?

Also if there was a double free shouldn't we fix that in a small
backportable patch first (not that I see such a fix anywhere)?