Re: [PATCH 13/18] libxfs: straighten out libxfs_writebuf confusion

Darrick J. Wong
2020-02-21T15:54:22Z

On Fri, Feb 21, 2020 at 06:53:05AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 19, 2020 at 05:43:55PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > libxfs_writebuf is not a well named function -- it marks the buffer
> > dirty and then releases the caller's reference. The actual write comes
> > when the cache is flushed, either because someone explicitly told the
> > cache to flush or because we started buffer reclaim.
> >
> > Make the buffer release explicit in the callers and rename the function
> > to say what it actually does -- it marks the buffer dirty outside of
> > transaction context.
>
> FYI, before we made all buffer writes delwri or sync in the kernel the
> equivalent function was called xfs_buf_bawrite.

Heh, yeah... I've been reviewing old Unixen books lately and finally
know where all those weird names came from.

> But I'm not sure that
> was a better name. But maybe libxfs_buf_mark_dirty is a tad better?

Ok.

--D

> Otherwise looks good.
>