From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: improve error message when we can't allocate memory for xfs_buf
Date: Fri, 21 Feb 2020 07:49:56 -0800 [thread overview]
Message-ID: <20200221154956.GA9866@infradead.org> (raw)
In-Reply-To: <20200221154132.GQ9506@magnolia>
On Fri, Feb 21, 2020 at 07:41:32AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> If xfs_buf_get_map can't allocate enough memory for the buffer it's
> trying to create, it'll cough up an error about not being able to
> allocate "pagesn". That's not particularly helpful (and if we're really
> out of memory the message is very spammy) so change the message to tell
> us how many pages were actually requested, and ratelimit it too.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-02-21 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 15:41 [PATCH] xfs: improve error message when we can't allocate memory for xfs_buf Darrick J. Wong
2020-02-21 15:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221154956.GA9866@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox