From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7998CC35656 for ; Fri, 21 Feb 2020 16:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AC0F20656 for ; Fri, 21 Feb 2020 16:00:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="DoQsoYFV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728684AbgBUQAn (ORCPT ); Fri, 21 Feb 2020 11:00:43 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:41206 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728668AbgBUQAn (ORCPT ); Fri, 21 Feb 2020 11:00:43 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01LFrYWo173161; Fri, 21 Feb 2020 16:00:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=FiD7dgguPbwoGGmLfZQpLxN4xq+obh7j8t6KnbaoSAI=; b=DoQsoYFVZhZrKpgdgz9E/PTo9cxp74vZs7fFs5Z7CTqMB8FAV263YSr9NUEeFkS1kaM0 OPmwnM9HSnz7469byxbTzP49kY3ZeroQvUjWZcskfOCIO+8+d7vSOmTx4ocWnuCAZsR9 ymguM4jlumzKbxvbfeYnYpsjz5JcWc2OUyhEIUWUxM/3y0rVouQNVv4dPdl399eWUz92 cA1ueevN++W2PirOsE9Skgu6tEyH/HLZMKaByOmQlW6nZT8A4zJsa8a37FcWS1RP37iE 4+qqM6dJVHQbad0KteNxRHD+AxXzYp8KNH+4KW/t0KMvThintnx//MHQdxEclvB+N2ul JQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2y8udkscdg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Feb 2020 16:00:38 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01LFvqfZ058574; Fri, 21 Feb 2020 16:00:37 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2y8ud6ya8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Feb 2020 16:00:37 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 01LG0aEa012975; Fri, 21 Feb 2020 16:00:36 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 21 Feb 2020 08:00:36 -0800 Date: Fri, 21 Feb 2020 08:00:35 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 15/18] libxfs: hide libxfs_{get,put}bufr Message-ID: <20200221160035.GV9506@magnolia> References: <158216295405.602314.2094526611933874427.stgit@magnolia> <158216304905.602314.17780460003947176973.stgit@magnolia> <20200221145354.GM15358@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221145354.GM15358@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9538 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxlogscore=907 suspectscore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210119 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9538 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 mlxscore=0 clxscore=1015 malwarescore=0 mlxlogscore=980 phishscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210119 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Feb 21, 2020 at 06:53:54AM -0800, Christoph Hellwig wrote: > On Wed, Feb 19, 2020 at 05:44:09PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Hide these two functions because they're not used outside of rdwr.c. > > Can we also pick a better name? That r postfix always seem very strange > to me. They're odd, but I also don't really have a good suggestion... getbufr -> xfs_buf_get_raw? putbufr -> xfs_buf_commit? --D