From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A679C35646 for ; Fri, 21 Feb 2020 16:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F13B92067D for ; Fri, 21 Feb 2020 16:01:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="PCCKzMin" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728835AbgBUQBS (ORCPT ); Fri, 21 Feb 2020 11:01:18 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:41920 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728822AbgBUQBS (ORCPT ); Fri, 21 Feb 2020 11:01:18 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01LFrY1P173183; Fri, 21 Feb 2020 16:01:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=EwA1nfJHZ1Ldd76y0WlKZ5g/alQsXHPhfqgDRoybgfA=; b=PCCKzMinKz4H0GNm+gmwODJx96jgM6P/+VPzXhDAP3eEuDNIXr5OejxG6sNQOtx3gsjg /NlicvfS5bbrSHLb8E29GbkJBEUNR+CZqdnLY8Qwjc67ULVI/wYTkbvvVHBucUPhQfDB vV53wV8Fj/UL93G1p8uxvyjQQX38TEN3k7hQBohZ/0rz0Q2bGwrkRDwdLbkAdUy1XHOq 7rnxalQIEZ7dV+CnTWzw80mzXiF4YOCZdhHMwZyunF9xvwxw01AdltVUig4UaIXfjbwo pBVY8rcYDhJYUw/ViYsRvTQHvL5sEbRmi+5yAgMhYE6pfff9msDHihkSTpoOfCMWZr43 HQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2y8udksck8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Feb 2020 16:01:14 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01LFw1nH087109; Fri, 21 Feb 2020 16:01:13 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2y8ud92uh0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Feb 2020 16:01:11 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01LG19Za018785; Fri, 21 Feb 2020 16:01:10 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 21 Feb 2020 08:01:09 -0800 Date: Fri, 21 Feb 2020 08:01:08 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 03/14] libxfs: make libxfs_buf_get_map return an error code Message-ID: <20200221160108.GW9506@magnolia> References: <158216306957.603628.16404096061228456718.stgit@magnolia> <158216308793.603628.12888791331568943049.stgit@magnolia> <20200221145743.GS15358@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221145743.GS15358@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9538 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=725 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210119 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9538 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 mlxscore=0 clxscore=1015 malwarescore=0 mlxlogscore=800 phishscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210119 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Feb 21, 2020 at 06:57:43AM -0800, Christoph Hellwig wrote: > > @@ -120,8 +121,9 @@ pf_queue_io( > > * the lock holder is either reading it from disk himself or > > * completely overwriting it this behaviour is perfectly fine. > > > - bp = libxfs_buf_get_map(mp->m_dev, map, nmaps, LIBXFS_GETBUF_TRYLOCK); > > - if (!bp) > > + error = -libxfs_buf_get_map(mp->m_dev, map, nmaps, LIBXFS_GETBUF_TRYLOCK, > > This adds an overly long line. Oops, will fix that. --D > Otherwise looks good: > > Reviewed-by: Christoph Hellwig