Re: [PATCH 03/14] libxfs: make libxfs_buf_get_map return an error code

Darrick J. Wong
2020-02-21T16:01:19Z

On Fri, Feb 21, 2020 at 06:57:43AM -0800, Christoph Hellwig wrote:
> > @@ -120,8 +121,9 @@ pf_queue_io(
> > * the lock holder is either reading it from disk himself or
> > * completely overwriting it this behaviour is perfectly fine.
>
> > - bp = libxfs_buf_get_map(mp->m_dev, map, nmaps, LIBXFS_GETBUF_TRYLOCK);
> > - if (!bp)
> > + error = -libxfs_buf_get_map(mp->m_dev, map, nmaps, LIBXFS_GETBUF_TRYLOCK,
>
> This adds an overly long line.

Oops, will fix that.

--D

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>