From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org,
Allison Collins <allison.henderson@oracle.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH 09/31] xfs: move struct xfs_da_args to xfs_types.h
Date: Mon, 24 Feb 2020 20:56:15 +0100 [thread overview]
Message-ID: <20200224195615.GA10432@lst.de> (raw)
In-Reply-To: <20200221225728.GX10776@dread.disaster.area>
On Sat, Feb 22, 2020 at 09:57:28AM +1100, Dave Chinner wrote:
> On Fri, Feb 21, 2020 at 06:11:32AM -0800, Christoph Hellwig wrote:
> > To allow passing a struct xfs_da_args to the high-level attr helpers
> > it needs to be easily includable by files like xfs_xattr.c. Move the
> > struct definition to xfs_types.h to allow for that.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > fs/xfs/libxfs/xfs_da_btree.h | 64 ------------------------------------
> > fs/xfs/libxfs/xfs_types.h | 60 +++++++++++++++++++++++++++++++++
> > 2 files changed, 60 insertions(+), 64 deletions(-)
>
> This seems way too broad. Stuff in fs/xfs/libxfs/xfs_types.h is
> really for fundamental XFS types, not for complex, subsystem
> specific API structures.
>
> Why can't the xattr code simply include what it needs to get this
> structure from xfs_da_btree.h like everything else does? Indeed,
> fs/xfs/xfs_xattr.c already includes xfs_da_format.h, so it should be
> able to directly include xfs_da_btree.h without much extra hassle.
>
> Hence I don't really see why making this structure globally visible
> is actually necessary, especially as the function prototypes in
> header files can simply use a forward declaration of struct
> xfs_da_args....
Forward declarations aren't the problem, but I wanted to avoid having
to pull xfs_da_btree.h into all users of the external xattr API. It
turns out that is just three new files, so it probably isn't too bad.
I have a new tree with this move dropped, but I'm going to wait a little
before I resend to see if there are any other comments.
next prev parent reply other threads:[~2020-02-24 19:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 14:11 clean up the attr interface v5 Christoph Hellwig
2020-02-21 14:11 ` [PATCH 01/31] xfs: reject invalid flags combinations in XFS_IOC_ATTRLIST_BY_HANDLE Christoph Hellwig
2020-02-21 14:11 ` [PATCH 02/31] xfs: remove the ATTR_INCOMPLETE flag Christoph Hellwig
2020-02-21 14:11 ` [PATCH 03/31] xfs: merge xfs_attr_remove into xfs_attr_set Christoph Hellwig
2020-02-21 15:15 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 04/31] xfs: merge xfs_attrmulti_attr_remove into xfs_attrmulti_attr_set Christoph Hellwig
2020-02-21 14:11 ` [PATCH 05/31] xfs: use strndup_user in XFS_IOC_ATTRMULTI_BY_HANDLE Christoph Hellwig
2020-02-21 14:11 ` [PATCH 06/31] xfs: factor out a helper for a single XFS_IOC_ATTRMULTI_BY_HANDLE op Christoph Hellwig
2020-02-21 15:17 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 07/31] xfs: remove the name == NULL check from xfs_attr_args_init Christoph Hellwig
2020-02-21 14:11 ` [PATCH 08/31] xfs: remove the MAXNAMELEN " Christoph Hellwig
2020-02-21 14:11 ` [PATCH 09/31] xfs: move struct xfs_da_args to xfs_types.h Christoph Hellwig
2020-02-21 22:57 ` Dave Chinner
2020-02-24 19:56 ` Christoph Hellwig [this message]
2020-02-21 14:11 ` [PATCH 10/31] xfs: turn xfs_da_args.value into a void pointer Christoph Hellwig
2020-02-21 14:11 ` [PATCH 11/31] xfs: pass an initialized xfs_da_args structure to xfs_attr_set Christoph Hellwig
2020-02-21 14:11 ` [PATCH 12/31] xfs: pass an initialized xfs_da_args to xfs_attr_get Christoph Hellwig
2020-02-21 14:11 ` [PATCH 13/31] xfs: remove the xfs_inode argument to xfs_attr_get_ilocked Christoph Hellwig
2020-02-21 14:11 ` [PATCH 14/31] xfs: remove ATTR_KERNOVAL Christoph Hellwig
2020-02-21 14:11 ` [PATCH 15/31] xfs: remove ATTR_ALLOC and XFS_DA_OP_ALLOCVAL Christoph Hellwig
2020-02-21 15:19 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 16/31] xfs: replace ATTR_KERNOTIME with XFS_DA_OP_NOTIME Christoph Hellwig
2020-02-21 14:11 ` [PATCH 17/31] xfs: factor out a xfs_attr_match helper Christoph Hellwig
2020-02-21 14:11 ` [PATCH 18/31] xfs: cleanup struct xfs_attr_list_context Christoph Hellwig
2020-02-21 14:11 ` [PATCH 19/31] xfs: remove the unused ATTR_ENTRY macro Christoph Hellwig
2020-02-21 14:11 ` [PATCH 20/31] xfs: open code ATTR_ENTSIZE Christoph Hellwig
2020-02-21 15:21 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 21/31] xfs: move the legacy xfs_attr_list to xfs_ioctl.c Christoph Hellwig
2020-02-21 15:23 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 22/31] xfs: rename xfs_attr_list_int to xfs_attr_list Christoph Hellwig
2020-02-21 14:11 ` [PATCH 23/31] xfs: lift common checks into xfs_ioc_attr_list Christoph Hellwig
2020-02-21 14:11 ` [PATCH 24/31] xfs: lift buffer allocation " Christoph Hellwig
2020-02-21 14:11 ` [PATCH 25/31] xfs: lift cursor copy in/out " Christoph Hellwig
2020-02-21 14:11 ` [PATCH 26/31] xfs: improve xfs_forget_acl Christoph Hellwig
2020-02-21 14:11 ` [PATCH 27/31] xfs: clean up the ATTR_REPLACE checks Christoph Hellwig
2020-02-21 14:11 ` [PATCH 28/31] xfs: clean up the attr flag confusion Christoph Hellwig
2020-02-21 15:26 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 29/31] xfs: remove XFS_DA_OP_INCOMPLETE Christoph Hellwig
2020-02-21 15:27 ` Darrick J. Wong
2020-02-21 14:11 ` [PATCH 30/31] xfs: embedded the attrlist cursor into struct xfs_attr_list_context Christoph Hellwig
2020-02-21 14:11 ` [PATCH 31/31] xfs: clean up bufsize alignment in xfs_ioc_attr_list Christoph Hellwig
2020-02-21 15:28 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-02-17 12:59 clean up the attr interface v4 Christoph Hellwig
2020-02-17 12:59 ` [PATCH 09/31] xfs: move struct xfs_da_args to xfs_types.h Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224195615.GA10432@lst.de \
--to=hch@lst.de \
--cc=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).