[PATCH 5/7] mkfs: check that metadata updates have been committed

Darrick J. Wong
2020-02-28T23:36:16Z

From: Darrick J. Wong <darrick.wong@oracle.com>

Make sure that all the metadata we wrote in the process of formatting
the filesystem have been written correctly, or exit with failure.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
mkfs/xfs_mkfs.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 0f84860f..bbc2da83 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3940,8 +3940,11 @@ main(
(XFS_BUF_TO_SBP(buf))->sb_inprogress = 0;
libxfs_writebuf(buf, LIBXFS_EXIT_ON_FAILURE);

- libxfs_umount(mp);
- libxfs_destroy(&xi);
+ /* Exit w/ failure if anything failed to get written to our new fs. */
+ error = -libxfs_umount(mp);
+ if (error)
+ exit(1);

+ libxfs_destroy(&xi);
return 0;
}