Re: [PATCH 4/7] libxfs: flush all dirty buffers and report errors when unmounting filesystem

Christoph Hellwig
2020-02-25T17:37:31Z

On Mon, Feb 24, 2020 at 04:10:53PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Teach libxfs_umount to flush all dirty buffers when unmounting the
> filesystem, to log write verifier errors and IO errors, and to return an
> error code when things go wrong. Subsequent patches will teach critical
> utilities to exit with EXIT_FAILURE when this happens.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>