* [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check()
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
@ 2020-02-23 23:16 ` Jules Irenge
2020-02-25 15:44 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
To: boqun.feng
Cc: jbi.octave, linux-kernel, Darrick J. Wong,
supporter:XFS FILESYSTEM
Sparse reports a warning at xfs_ail_check()
warning: context imbalance in xfs_ail_check() - unexpected unlock
The root cause is the missing annotation at xfs_ail_check()
Add the missing __must_hold(&ailp->ail_lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
fs/xfs/xfs_trans_ail.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 00cc5b8734be..58d4ef1b4c05 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -32,6 +32,7 @@ STATIC void
xfs_ail_check(
struct xfs_ail *ailp,
struct xfs_log_item *lip)
+ __must_hold(&ailp->ail_lock)
{
struct xfs_log_item *prev_lip;
struct xfs_log_item *next_lip;
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check()
2020-02-23 23:16 ` [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check() Jules Irenge
@ 2020-02-25 15:44 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-02-25 15:44 UTC (permalink / raw)
To: Jules Irenge; +Cc: boqun.feng, linux-kernel, supporter:XFS FILESYSTEM
On Sun, Feb 23, 2020 at 11:16:44PM +0000, Jules Irenge wrote:
> Sparse reports a warning at xfs_ail_check()
>
> warning: context imbalance in xfs_ail_check() - unexpected unlock
>
> The root cause is the missing annotation at xfs_ail_check()
>
> Add the missing __must_hold(&ailp->ail_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Seems reasonable, though I'm wondering if this is a treewide change you
seek to apply yourself, or merely a large patch series to merge through
the individual subsystem maintainers?
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_trans_ail.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 00cc5b8734be..58d4ef1b4c05 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -32,6 +32,7 @@ STATIC void
> xfs_ail_check(
> struct xfs_ail *ailp,
> struct xfs_log_item *lip)
> + __must_hold(&ailp->ail_lock)
> {
> struct xfs_log_item *prev_lip;
> struct xfs_log_item *next_lip;
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-25 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0/30>
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:16 ` [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check() Jules Irenge
2020-02-25 15:44 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox