[PATCH 2/7] libxfs: complain when write IOs fail

Darrick J. Wong
2020-02-25T00:10:49Z

From: Darrick J. Wong <darrick.wong@oracle.com>

Complain whenever a metadata write fails.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
libxfs/rdwr.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 2e9f66cc..8b47d438 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -1149,7 +1149,12 @@ libxfs_writebufr(xfs_buf_t *bp)
(long long)LIBXFS_BBTOOFF64(bp->b_bn),
(long long)bp->b_bn, bp, bp->b_error);
#endif
- if (!bp->b_error) {
+ if (bp->b_error) {
+ fprintf(stderr,
+ _("%s: write failed on %s bno 0x%llx/0x%x, err=%d\n"),
+ __func__, bp->b_ops->name,
+ (long long)bp->b_bn, bp->b_bcount, -bp->b_error);
+ } else {
bp->b_flags |= LIBXFS_B_UPTODATE;
bp->b_flags &= ~(LIBXFS_B_DIRTY | LIBXFS_B_EXIT |
LIBXFS_B_UNCHECKED);