Re: [PATCH 7/7] libfrog: always fsync when flushing a device

Christoph Hellwig
2020-02-25T17:38:56Z

On Mon, Feb 24, 2020 at 04:11:11PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Always call fsync() when we're flushing a device, even if it is a block
> device. It's probably redundant to call fsync /and/ BLKFLSBUF, but the
> latter has odd behavior so we want to make sure the standard flush
> methods have a chance to run first.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Brian Foster <bfoster@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>