Re: [PATCH 17/25] libxfs: straighten out libxfs_writebuf naming confusion

Christoph Hellwig
2020-02-25T17:50:31Z

On Mon, Feb 24, 2020 at 04:13:16PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> libxfs_writebuf is not a well named function -- it marks the buffer
> dirty and then releases the caller's reference. The actual write comes
> when the cache is flushed, either because someone explicitly told the
> cache to flush or because we started buffer reclaim.
>
> Make the buffer release explicit in the callers and rename the function
> to say what it actually does -- it marks the buffer dirty outside of
> transaction context.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>