Re: [PATCH 18/25] libxfs: remove unused flags parameter to libxfs_buf_mark_dirty

Darrick J. Wong
2020-02-25T18:53:02Z

On Tue, Feb 25, 2020 at 09:51:07AM -0800, Christoph Hellwig wrote:
> On Mon, Feb 24, 2020 at 04:13:23PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Nobody uses the flags parameter, so get rid of it.
>
> Looks good, but wouldn't it make sense to fold this into the previous
> patch instead of modifying all callers twice?

I'll ask Eric if he prefers it this way or combined. Or I guess you
could, if you run into him later today. ;)

--D

> Reviewed-by: Christoph Hellwig <hch@lst.de>