Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig

Darrick J. Wong
2020-02-25T00:56:03Z

On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote:
> The old ARM OABI's structure alignment quirks break xfs disk structures,
> let's just move on and disallow it rather than playing whack-a-mole
> for the infrequent times someone selects this old config, which is
> usually during "make randconfig" tests.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index e685299eb3d2..043624bd4ab2 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -2,6 +2,8 @@
> config XFS_FS
> tristate "XFS filesystem support"
> depends on BLOCK
> + # We don't support OABI structure alignment on ARM

Should this limitation be documented in the help screen?

> + depends on (!ARM || AEABI)
> select EXPORTFS
> select LIBCRC32C
> select FS_IOMAP
>