Re: [PATCH 2/2] libfrog: move topology.[ch] to libxfs

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Wed, Dec 18, 2019 at 07:04:32PM -0600, Eric Sandeen wrote:
> On 12/18/19 6:12 PM, Darrick J. Wong wrote:
> > On Wed, Dec 18, 2019 at 05:26:44PM -0600, Eric Sandeen wrote:
> >> On 12/18/19 5:14 PM, Darrick J. Wong wrote:
> >>> From: Darrick J. Wong <darrick.wong@oracle.com>
> >>>
> >>> The functions in libfrog/topology.c rely on internal libxfs symbols and
> >>> functions, so move this file from libfrog to libxfs.
> >>
> >> None of this is used anywhere but mkfs & repair, and it's not really
> >> part of libxfs per se (i.e. it shares nothing w/ kernel code).
> >>
> >> It used to be in libxcmd.  Perhaps it should just be moved back?
> > 
> > But the whole point of getting it out of libxcmd was that it had nothing
> > to do with command processing.
> 
> Yeah I almost asked that.  ;)
>  
> > I dunno, I kinda wonder if this should just be libxtopo or something.
> 
> bleargh, not sure what it gains us to keep creating little internal libraries,
> either.
> 
> I guess I don't really care, tbh.  Doesn't feel right to shove unrelated stuff
> into libxfs/ though, when its main rationale is to share kernel code.

OTOH, not having it is now getting in the way of me being able to turn
XFS_BUF_SET_PRIORITY into a static inline function because the priority
functions reference libxfs_bcache, which ofc only exists in libxfs.  We
have gotten away with this because the preprocessor doesn't care, but
the compiler will.

--D

> -Eric