From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3844C4BA06 for ; Tue, 25 Feb 2020 23:51:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93AFA222C2 for ; Tue, 25 Feb 2020 23:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729493AbgBYXvS (ORCPT ); Tue, 25 Feb 2020 18:51:18 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:50293 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728865AbgBYXvR (ORCPT ); Tue, 25 Feb 2020 18:51:17 -0500 Received: from dread.disaster.area (pa49-195-202-68.pa.nsw.optusnet.com.au [49.195.202.68]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id E13BF3A2DD8; Wed, 26 Feb 2020 10:51:13 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j6jyq-0004of-4c; Wed, 26 Feb 2020 10:51:12 +1100 Date: Wed, 26 Feb 2020 10:51:12 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Chandan Rajendra , "Darrick J . Wong" Subject: Re: [PATCH 05/30] xfs: use strndup_user in XFS_IOC_ATTRMULTI_BY_HANDLE Message-ID: <20200225235112.GP10776@dread.disaster.area> References: <20200225231012.735245-1-hch@lst.de> <20200225231012.735245-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225231012.735245-6-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=mqTaRPt+QsUAtUurwE173Q==:117 a=mqTaRPt+QsUAtUurwE173Q==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=pGLkceISAAAA:8 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=sL5fizlmL7ONaEgnRtAA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Feb 25, 2020 at 03:09:47PM -0800, Christoph Hellwig wrote: > Simplify the user copy code by using strndup_user. This means that we > now do one memory allocation per operation instead of one per ioctl, > but memory allocations are cheap compared to the actual file system > operations. Also the error for an invalid path is now EINVAL or EFAULT > instead of the previous odd and undocumented ERANGE. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Chandan Rajendra > Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_ioctl.c | 17 +++++------------ > fs/xfs/xfs_ioctl32.c | 17 +++++------------ > 2 files changed, 10 insertions(+), 24 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com