From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD3BC4BA09 for ; Wed, 26 Feb 2020 01:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA0B321927 for ; Wed, 26 Feb 2020 01:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729170AbgBZBEY (ORCPT ); Tue, 25 Feb 2020 20:04:24 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:52792 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729277AbgBZBEY (ORCPT ); Tue, 25 Feb 2020 20:04:24 -0500 Received: from dread.disaster.area (pa49-195-202-68.pa.nsw.optusnet.com.au [49.195.202.68]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 011717E9BB1; Wed, 26 Feb 2020 12:04:21 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j6l7c-0005KW-At; Wed, 26 Feb 2020 12:04:20 +1100 Date: Wed, 26 Feb 2020 12:04:20 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: [PATCH 30/30] xfs: clean up bufsize alignment in xfs_ioc_attr_list Message-ID: <20200226010420.GX10776@dread.disaster.area> References: <20200225231012.735245-1-hch@lst.de> <20200225231012.735245-31-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225231012.735245-31-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=mqTaRPt+QsUAtUurwE173Q==:117 a=mqTaRPt+QsUAtUurwE173Q==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=jWo7ng2T0DGGxPGrpB8A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Feb 25, 2020 at 03:10:12PM -0800, Christoph Hellwig wrote: > Use the round_down macro, and use the size of the uint32 type we > use in the callback that fills the buffer to make the code a little > more clear - the size of it is always the same as int for platforms > that Linux runs on. > > Suggested-by: Dave Chinner > Signed-off-by: Christoph Hellwig > --- > fs/xfs/xfs_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > index 58fd2d219972..c805fdf4ea39 100644 > --- a/fs/xfs/xfs_ioctl.c > +++ b/fs/xfs/xfs_ioctl.c > @@ -415,7 +415,7 @@ xfs_ioc_attr_list( > context.resynch = 1; > context.attr_filter = xfs_attr_filter(flags); > context.buffer = buffer; > - context.bufsize = (bufsize & ~(sizeof(int)-1)); /* align */ > + context.bufsize = round_down(bufsize, sizeof(uint32_t)); > context.firstu = context.bufsize; > context.put_listent = xfs_ioc_attr_put_listent; Much nicer. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com