From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97CDC4BA13 for ; Wed, 26 Feb 2020 14:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B9AE21D7E for ; Wed, 26 Feb 2020 14:50:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UtUC9d7c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbgBZOuv (ORCPT ); Wed, 26 Feb 2020 09:50:51 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43430 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbgBZOuv (ORCPT ); Wed, 26 Feb 2020 09:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l2WBiCb5duYJRA9nKpihqrJOH1Qjg6utSrFiu8qAdtc=; b=UtUC9d7cZWT4BRbWaLU+EiTUS1 6+6Kd9gfBrL0gRs1/835RTvbJj2cvx8UJOLuLW/Bb6ES/okhRXF7YGi2X5GNzBTLwP8ZZgemX3RlV hjdulGXTgYSE5cZtMwV5mZGk9lkPbGfddFgpQUt6CcM4v7GZNPsBE/4eqTsA0ZpEhn+N4mX4Mb9Wm K2tELBaH7+KeOg2Ty2eOTxV4SeRcKiTCIF6w347CKoTyz9O7F0gtxGaD0J77R4QuxXOWb1kr/GBAz UZu/L868QpIA2J5dVIVH5+eJA3qYi6cxtd+Ov0n+JCj4SZYKXgnqLPJ64k2pzc5+aO7nf8Ee/kCkK 6WZ+MyGw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6y1Q-0004xx-CO; Wed, 26 Feb 2020 14:50:48 +0000 Date: Wed, 26 Feb 2020 06:50:48 -0800 From: Christoph Hellwig To: Qian Cai Cc: darrick.wong@oracle.com, hch@infradead.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] xfs: fix an undefined behaviour in _da3_path_shift Message-ID: <20200226145048.GA19034@infradead.org> References: <20200226020637.1065-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226020637.1065-1-cai@lca.pw> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig