From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C7DC4BA24 for ; Wed, 26 Feb 2020 21:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE28521D7E for ; Wed, 26 Feb 2020 21:40:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727640AbgBZVkG (ORCPT ); Wed, 26 Feb 2020 16:40:06 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:35316 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727637AbgBZVkG (ORCPT ); Wed, 26 Feb 2020 16:40:06 -0500 Received: from dread.disaster.area (pa49-195-202-68.pa.nsw.optusnet.com.au [49.195.202.68]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id C00997EAAD7; Thu, 27 Feb 2020 08:40:02 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j74PR-0004GE-JN; Thu, 27 Feb 2020 08:40:01 +1100 Date: Thu, 27 Feb 2020 08:40:01 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: [PATCH 32/32] xfs: switch xfs_attrmulti_attr_get to lazy attr buffer allocation Message-ID: <20200226214001.GZ10776@dread.disaster.area> References: <20200226202306.871241-1-hch@lst.de> <20200226202306.871241-33-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226202306.871241-33-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=mqTaRPt+QsUAtUurwE173Q==:117 a=mqTaRPt+QsUAtUurwE173Q==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=eDeCxtxDABJdaOS9px8A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Feb 26, 2020 at 12:23:06PM -0800, Christoph Hellwig wrote: > Let the low-level attr code only allocate the needed buffer size > for xfs_attrmulti_attr_get instead of allocating the upper bound > at the top of the call chain. > > Suggested-by: Dave Chinner > Signed-off-by: Christoph Hellwig > --- > fs/xfs/xfs_ioctl.c | 4 ---- > 1 file changed, 4 deletions(-) Yup, looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com