From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FF7C3F2D1 for ; Sun, 1 Mar 2020 20:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30D54222C4 for ; Sun, 1 Mar 2020 20:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgCAUzf (ORCPT ); Sun, 1 Mar 2020 15:55:35 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:44592 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726188AbgCAUzf (ORCPT ); Sun, 1 Mar 2020 15:55:35 -0500 Received: from dread.disaster.area (pa49-195-202-68.pa.nsw.optusnet.com.au [49.195.202.68]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 93F693A1A1D; Mon, 2 Mar 2020 07:55:33 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j8Vca-0003ql-0O; Mon, 02 Mar 2020 07:55:32 +1100 Date: Mon, 2 Mar 2020 07:55:31 +1100 From: Dave Chinner To: Eric Sandeen Cc: linux-xfs , "Darrick J. Wong" Subject: Re: [PATCH] xfs_admin: revert online label setting ability Message-ID: <20200301205531.GD10776@dread.disaster.area> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=mqTaRPt+QsUAtUurwE173Q==:117 a=mqTaRPt+QsUAtUurwE173Q==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=SS2py6AdgQ4A:10 a=7-415B0cAAAA:8 a=F91YJfGEYfWdvyOHcZ4A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Mar 01, 2020 at 09:50:03AM -0800, Eric Sandeen wrote: > The changes to xfs_admin which allowed online label setting via > ioctl had some unintended consequences in terms of changing command > order and processing. It's going to be somewhat tricky to fix, so > back it out for now. What are the symptoms and behaviour of these "unintended consequences"? And why are they tricky to fix? Cheers, Dave. -- Dave Chinner david@fromorbit.com