Re: [PATCH 2/4] xfs: check owner of dir3 free blocks

Allison Collins
2020-03-02T18:12:05Z

On 2/28/20 6:48 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Check the owner field of dir3 free block headers.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Ok, looks fine:
Reviewed-by: Allison Collins <allison.henderson@oracle.com>

> ---
> fs/xfs/libxfs/xfs_dir2_node.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>
> diff --git a/fs/xfs/libxfs/xfs_dir2_node.c b/fs/xfs/libxfs/xfs_dir2_node.c
> index f622ede7119e..79b917e62ac3 100644
> --- a/fs/xfs/libxfs/xfs_dir2_node.c
> +++ b/fs/xfs/libxfs/xfs_dir2_node.c
> @@ -194,6 +194,8 @@ xfs_dir3_free_header_check(
> return __this_address;
> if (be32_to_cpu(hdr3->nvalid) < be32_to_cpu(hdr3->nused))
> return __this_address;
> + if (be64_to_cpu(hdr3->hdr.owner) != dp->i_ino)
> + return __this_address;
> } else {
> struct xfs_dir2_free_hdr *hdr = bp->b_addr;
>
>