Re: [PATCH 4/4] xfs: check owner of dir3 blocks

Christoph Hellwig
2020-03-05T16:51:29Z

On Fri, Feb 28, 2020 at 05:49:01PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Check the owner field of dir3 block headers.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

> + xfs_verifier_error(*bpp, -EFSCORRUPTED, fa);
> + (*bpp)->b_flags &= ~XBF_DONE;
> + xfs_trans_brelse(tp, *bpp);
> + *bpp = NULL;
> + return -EFSCORRUPTED;

Although I wonder if we should factor this repeated sniplet into a
helper..