Re: [PATCH 03/11] xfs: refactor and split xfs_log_done()

Christoph Hellwig
2020-03-05T15:20:14Z

On Thu, Mar 05, 2020 at 08:28:18AM +1100, Dave Chinner wrote:
> On Wed, Mar 04, 2020 at 07:49:55AM -0800, Christoph Hellwig wrote:
> > > +int
> > > +xlog_write_done(
> > > + struct xlog *log,
> > > struct xlog_ticket *ticket,
> > > struct xlog_in_core **iclog,
> > > + xfs_lsn_t *lsn)
> > > {
> > > + if (XLOG_FORCED_SHUTDOWN(log))
> > > + return -EIO;
> > >
> > > + return xlog_commit_record(log, ticket, iclog, lsn);
> > > +}
> >
> > Can we just move the XLOG_FORCED_SHUTDOWN check into xlog_commit_record
> > and call xlog_commit_record directly?
>
> Next patch, because merging isn't obvious until the split is done.

Can you please at least avoid moving the code around in the next
patch then? With the function now non-static there shouldn't really
be any reason to move it.