Re: [PATCH 11/11] xfs: kill XLOG_TIC_INITED

Brian Foster
2020-03-05T18:08:28Z

On Wed, Mar 04, 2020 at 06:54:01PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> It is not longer used or checked by anything, so remove the last
> traces from the log ticket code.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

> fs/xfs/xfs_log.c | 1 -
> fs/xfs/xfs_log_priv.h | 6 ++----
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 89956484848f..b91efc5829e1 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -3529,7 +3529,6 @@ xlog_ticket_alloc(
> tic->t_ocnt = cnt;
> tic->t_tid = prandom_u32();
> tic->t_clientid = client;
> - tic->t_flags = XLOG_TIC_INITED;
> if (permanent)
> tic->t_flags |= XLOG_TIC_PERM_RESERV;
>
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 081d4c6de2c8..e989cf024ffe 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -51,13 +51,11 @@ enum xlog_iclog_state {
> };
>
> /*
> - * Flags to log ticket
> + * Log ticket flags
> */
> -#define XLOG_TIC_INITED 0x1 /* has been initialized */
> -#define XLOG_TIC_PERM_RESERV 0x2 /* permanent reservation */
> +#define XLOG_TIC_PERM_RESERV 0x1 /* permanent reservation */
>
> #define XLOG_TIC_FLAGS \
> - { XLOG_TIC_INITED, "XLOG_TIC_INITED" }, \
> { XLOG_TIC_PERM_RESERV, "XLOG_TIC_PERM_RESERV" }
>
> /*
> --
> 2.24.0.rc0
>