Re: [PATCH 06/11] xfs: move xlog_state_ioerror()

Christoph Hellwig
2020-03-05T15:21:23Z

On Thu, Mar 05, 2020 at 08:41:15AM +1100, Dave Chinner wrote:
> On Wed, Mar 04, 2020 at 07:51:40AM -0800, Christoph Hellwig wrote:
> > On Wed, Mar 04, 2020 at 06:53:56PM +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > To clean up unmount record writing error handling, we need to move
> > > xlog_state_ioerror() higher up in the file. Also move the setting of
> > > the XLOG_IO_ERROR state to inside the function.
> > >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> >
> > FYI, I have a pending series that kills xlog_state_ioerror and
> > XLOG_IO_ERROR. Let me send that out now that Brians fix is in for-next.
>
> Can you rebase that on top of this? removing IOERROR is a much more
> invasive and riskier set of state machine changes compared to what
> this patchset does. This patchset simplifies some of the error
> handling that handles IOERROR, too...

I find this lipstick on the pig here a little pointless, especially
moving things around that are planned to be removed..