Re: [PATCH v3] iomap: Remove pgoff from tracepoints

[Dave Chinner <david@fromorbit.com>]

On Wed, Mar 04, 2020 at 09:54:29AM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox (Oracle) <willy@infradead.org>
> 
> The 'pgoff' displayed by the tracepoints wasn't a pgoff at all; it
> was a byte offset from the start of the file.  We already emit that in
> the form of the 'offset', so we can just remove pgoff.  That means we
> can remove 'page' as an argument to the tracepoint, and rename this
> type of tracepoint from being a page class to being a range class.
> 
> Fixes: 0b1b213fcf3a ("xfs: event tracing support")
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
> ---
> v2: Get rid of 'pgoff' instead of fixing it
> v3: Fix releasepage and writepage to actually set offset/length.
> 
>  buffered-io.c |    7 ++++---
>  trace.h       |   27 +++++++++++----------------
>  2 files changed, 15 insertions(+), 19 deletions(-)

With the range updates for release/writeage it looks good to me.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com