From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 11/11] xfs: kill XLOG_TIC_INITED
Date: Thu, 5 Mar 2020 13:08:22 -0500 [thread overview]
Message-ID: <20200305180822.GK28340@bfoster> (raw)
In-Reply-To: <20200304075401.21558-12-david@fromorbit.com>
On Wed, Mar 04, 2020 at 06:54:01PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> It is not longer used or checked by anything, so remove the last
> traces from the log ticket code.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_log.c | 1 -
> fs/xfs/xfs_log_priv.h | 6 ++----
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 89956484848f..b91efc5829e1 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -3529,7 +3529,6 @@ xlog_ticket_alloc(
> tic->t_ocnt = cnt;
> tic->t_tid = prandom_u32();
> tic->t_clientid = client;
> - tic->t_flags = XLOG_TIC_INITED;
> if (permanent)
> tic->t_flags |= XLOG_TIC_PERM_RESERV;
>
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 081d4c6de2c8..e989cf024ffe 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -51,13 +51,11 @@ enum xlog_iclog_state {
> };
>
> /*
> - * Flags to log ticket
> + * Log ticket flags
> */
> -#define XLOG_TIC_INITED 0x1 /* has been initialized */
> -#define XLOG_TIC_PERM_RESERV 0x2 /* permanent reservation */
> +#define XLOG_TIC_PERM_RESERV 0x1 /* permanent reservation */
>
> #define XLOG_TIC_FLAGS \
> - { XLOG_TIC_INITED, "XLOG_TIC_INITED" }, \
> { XLOG_TIC_PERM_RESERV, "XLOG_TIC_PERM_RESERV" }
>
> /*
> --
> 2.24.0.rc0
>
next prev parent reply other threads:[~2020-03-05 18:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 7:53 [PATCH 00/11] xfs: clean up log tickets and record writes Dave Chinner
2020-03-04 7:53 ` [PATCH 01/11] xfs: don't try to write a start record into every iclog Dave Chinner
2020-03-04 15:44 ` Christoph Hellwig
2020-03-04 21:26 ` Dave Chinner
2020-03-05 15:19 ` Christoph Hellwig
2020-03-05 18:05 ` Brian Foster
2020-03-04 7:53 ` [PATCH 02/11] xfs: re-order initial space accounting checks in xlog_write Dave Chinner
2020-03-05 18:05 ` Brian Foster
2020-03-04 7:53 ` [PATCH 03/11] xfs: refactor and split xfs_log_done() Dave Chinner
2020-03-04 15:49 ` Christoph Hellwig
2020-03-04 21:28 ` Dave Chinner
2020-03-05 15:20 ` Christoph Hellwig
2020-03-05 18:06 ` Brian Foster
2020-03-24 12:37 ` Christoph Hellwig
2020-03-04 7:53 ` [PATCH 04/11] xfs: merge xlog_commit_record with xlog_write_done() Dave Chinner
2020-03-04 15:50 ` Christoph Hellwig
2020-03-05 18:06 ` Brian Foster
2020-03-04 7:53 ` [PATCH 05/11] xfs: factor out unmount record writing Dave Chinner
2020-03-04 15:51 ` Christoph Hellwig
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 06/11] xfs: move xlog_state_ioerror() Dave Chinner
2020-03-04 15:51 ` Christoph Hellwig
2020-03-04 21:41 ` Dave Chinner
2020-03-05 15:21 ` Christoph Hellwig
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 07/11] xfs: clean up xlog_state_ioerror() Dave Chinner
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 08/11] xfs: rename the log unmount writing functions Dave Chinner
2020-03-04 15:52 ` Christoph Hellwig
2020-03-05 18:07 ` Brian Foster
2020-03-04 7:53 ` [PATCH 09/11] xfs: merge unmount record write iclog cleanup Dave Chinner
2020-03-04 15:53 ` Christoph Hellwig
2020-03-04 21:38 ` Dave Chinner
2020-03-05 15:27 ` Christoph Hellwig
2020-03-05 18:08 ` Brian Foster
2020-03-04 7:54 ` [PATCH 10/11] xfs: remove some stale comments from the log code Dave Chinner
2020-03-04 15:53 ` Christoph Hellwig
2020-03-05 18:08 ` Brian Foster
2020-03-04 7:54 ` [PATCH 11/11] xfs: kill XLOG_TIC_INITED Dave Chinner
2020-03-04 15:54 ` Christoph Hellwig
2020-03-05 18:08 ` Brian Foster [this message]
2020-03-05 16:05 ` [PATCH 00/11] xfs: clean up log tickets and record writes Christoph Hellwig
2020-03-05 21:42 ` Dave Chinner
2020-03-06 1:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305180822.GK28340@bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).