From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F8BC10F25 for ; Wed, 11 Mar 2020 05:14:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D0FE208C4 for ; Wed, 11 Mar 2020 05:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbgCKFOs (ORCPT ); Wed, 11 Mar 2020 01:14:48 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:46641 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgCKFOs (ORCPT ); Wed, 11 Mar 2020 01:14:48 -0400 Received: from dread.disaster.area (pa49-195-202-68.pa.nsw.optusnet.com.au [49.195.202.68]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id EE0577E9D2E; Wed, 11 Mar 2020 16:14:45 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jBthc-00073e-Jr; Wed, 11 Mar 2020 16:14:44 +1100 Date: Wed, 11 Mar 2020 16:14:44 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/2] xfs: fix use-after-free when aborting corrupt attr inactivation Message-ID: <20200311051444.GS10776@dread.disaster.area> References: <158388761806.939081.5340701470247161779.stgit@magnolia> <158388762432.939081.11036027889087941270.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158388762432.939081.11036027889087941270.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=mqTaRPt+QsUAtUurwE173Q==:117 a=mqTaRPt+QsUAtUurwE173Q==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=SS2py6AdgQ4A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=dESsUPskIBYsy0Bp6YkA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Mar 10, 2020 at 05:47:04PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Log the corrupt buffer before we release the buffer. > > Fixes: a5155b870d687 ("xfs: always log corruption errors") > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_attr_inactive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/fs/xfs/xfs_attr_inactive.c b/fs/xfs/xfs_attr_inactive.c > index bbfa6ba84dcd..fe8f60b59ec4 100644 > --- a/fs/xfs/xfs_attr_inactive.c > +++ b/fs/xfs/xfs_attr_inactive.c > @@ -145,8 +145,8 @@ xfs_attr3_node_inactive( > * Since this code is recursive (gasp!) we must protect ourselves. > */ > if (level > XFS_DA_NODE_MAXDEPTH) { > - xfs_trans_brelse(*trans, bp); /* no locks for later trans */ > xfs_buf_corruption_error(bp); > + xfs_trans_brelse(*trans, bp); /* no locks for later trans */ Yup, that needs fixing. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com