Re: [PATCH 2/2] xfs: fix xfs_rmap_has_other_keys usage of ECANCELED

Darrick J. Wong
2020-03-11T16:01:27Z

On Wed, Mar 11, 2020 at 08:52:44AM -0700, Christoph Hellwig wrote:
> On Wed, Mar 11, 2020 at 08:47:25AM -0700, Darrick J. Wong wrote:
> > On Tue, Mar 10, 2020 at 11:40:11PM -0700, Christoph Hellwig wrote:
> > > On Tue, Mar 10, 2020 at 05:47:10PM -0700, Darrick J. Wong wrote:
> > > > From: Darrick J. Wong <darrick.wong@oracle.com>
> > > >
> > > > In e7ee96dfb8c26, we converted all ITER_ABORT users to use ECANCELED
> > > > instead, but we forgot to teach xfs_rmap_has_other_keys not to return
> > > > that magic value to callers. Fix it now.
> > >
> > > This doesn't document the remap of the has_rmap flag. As far as I can
> > > tell that isn't needed now the caller checks for ECANCELED, but it
> > > takes a while to figure that out. It'll need to be documented properly
> > > in the commit log.
> >
> > "Fix it now by using ECANCELED both to abort the iteration and to signal
> > that we found another reverse mapping. This enables us to drop the
> > separate boolean flag." ?
>
> Sounds good.

Ok, I'll respin this one.

--D