From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 1/7] xfs: add a function to deal with corrupt buffers post-verifiers
Date: Wed, 11 Mar 2020 21:55:58 -0700 (PDT) [thread overview]
Message-ID: <20200312045558.GK8045@magnolia> (raw)
In-Reply-To: <20200312043723.GI10776@dread.disaster.area>
On Thu, Mar 12, 2020 at 03:37:23PM +1100, Dave Chinner wrote:
> On Wed, Mar 11, 2020 at 11:25:33AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Add a helper function to get rid of buffers that we have decided are
> > corrupt after the verifiers have run. This function is intended to
> > handle metadata checks that can't happen in the verifiers, such as
> > inter-block relationship checking. Note that we now mark the buffer
> > stale so that it will not end up on any LRU and will be purged on
> > release.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > v2: drop the (broken) dirty buffer check
>
> Looks good now.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cool, thanks for the review!
--D
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2020-03-12 4:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:47 [PATCH v2 0/7] xfs: fix errors in various verifiers Darrick J. Wong
2020-03-11 0:47 ` [PATCH 1/7] xfs: add a function to deal with corrupt buffers post-verifiers Darrick J. Wong
2020-03-11 5:35 ` Dave Chinner
2020-03-11 16:42 ` Darrick J. Wong
2020-03-11 18:25 ` [PATCH v2 " Darrick J. Wong
2020-03-12 4:37 ` Dave Chinner
2020-03-12 4:55 ` Darrick J. Wong [this message]
2020-03-11 0:47 ` [PATCH 2/7] xfs: xfs_buf_corruption_error should take __this_address Darrick J. Wong
2020-03-11 5:36 ` Dave Chinner
2020-03-11 0:47 ` [PATCH 3/7] xfs: fix buffer corruption reporting when xfs_dir3_free_header_check fails Darrick J. Wong
2020-03-11 5:39 ` Dave Chinner
2020-03-11 0:47 ` [PATCH 4/7] xfs: don't ever return a stale pointer from __xfs_dir3_free_read Darrick J. Wong
2020-03-11 5:47 ` Dave Chinner
2020-03-11 0:47 ` [PATCH 5/7] xfs: check owner of dir3 free blocks Darrick J. Wong
2020-03-11 5:47 ` Dave Chinner
2020-03-11 0:47 ` [PATCH 6/7] xfs: check owner of dir3 data blocks Darrick J. Wong
2020-03-11 5:51 ` Dave Chinner
2020-03-11 0:47 ` [PATCH 7/7] xfs: check owner of dir3 blocks Darrick J. Wong
2020-03-11 5:52 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312045558.GK8045@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox