From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 798ADC10DCE for ; Thu, 12 Mar 2020 23:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E1A6206F7 for ; Thu, 12 Mar 2020 23:45:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="s55zEvx0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgCLXpV (ORCPT ); Thu, 12 Mar 2020 19:45:21 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:53732 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbgCLXpU (ORCPT ); Thu, 12 Mar 2020 19:45:20 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02CNguuw098312; Thu, 12 Mar 2020 23:45:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=9k/mmV8Ih/H/htO4li8D7Rt95FUip+Og4rVVJecn664=; b=s55zEvx0UF3OYXYRMZR+9gbVWOAOsPaJPOAQ+SHmWvD9fGowl1duEJ6fFYXll/mfMCCd oOcaO5XZ5t8Lixjh7aiL75Qv1npbfuzWmkPwdo0nO5klytHWNUsnM3g2n2zC/rXurKUS 9bQpjOYrO9zTU/XC6BDZdGQ+nl8sxDYfULHKBGCJNznozZfWfWLBdNsVtcCzrpXmXq5W ZQm13zKlO9hYY3eQMNPjiOPAnmjLWiw/iVSOyN1YM8rJCDm7G+byn1cfZAWN+qzYGvSO QbsNZ4GWMJW39Wmxu0p6POe0lbqOMZ8L+BfwCAxIPR3ZP8rQawkD8QsAwZ/6st7VXUzM NA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2yqtaes4rs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 23:45:16 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02CNgLlv141573; Thu, 12 Mar 2020 23:45:15 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2yqtabah91-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 23:45:14 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02CNjDki030417; Thu, 12 Mar 2020 23:45:13 GMT Received: from localhost (/10.145.179.117) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Mar 2020 16:45:13 -0700 Date: Thu, 12 Mar 2020 16:45:12 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: [PATCH 2/5] xfs: remove the unused XLOG_UNMOUNT_REC_TYPE define Message-ID: <20200312234512.GT8045@magnolia> References: <20200312143959.583781-1-hch@lst.de> <20200312143959.583781-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312143959.583781-3-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9558 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003120117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9558 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003120117 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Mar 12, 2020 at 03:39:56PM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_log_priv.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h > index e400170ff4af..2b0aec37e73e 100644 > --- a/fs/xfs/xfs_log_priv.h > +++ b/fs/xfs/xfs_log_priv.h > @@ -525,12 +525,6 @@ xlog_cil_force(struct xlog *log) > xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence); > } > > -/* > - * Unmount record type is used as a pseudo transaction type for the ticket. > - * It's value must be outside the range of XFS_TRANS_* values. > - */ > -#define XLOG_UNMOUNT_REC_TYPE (-1U) > - > /* > * Wrapper function for waiting on a wait queue serialised against wakeups > * by a spinlock. This matches the semantics of all the wait queues used in the > -- > 2.24.1 >